On 12/11/20 5:35 PM, Darrick J. Wong wrote: >>> Finally, no, we can't have a truly empty log while the filesystem is >>> mounted because log transaction records must not be empty. Further, >>> we can only bring the log down to an "empty but not quite clean" >>> state while mounted, because if the log is actually marked clean and >>> we crash then log recovery will not run and so we will not clean up >>> files that were open-but-unlinked when the system crashed. > Whatever happened to Eric's patchset to make us process unlinked inodes > at mount time so that freeze images wouldn't require recovery? It suffered a fate typical of my patches. You observed an issue in a test, Dave did some brief triage, and I haven't gotten back to it. I'd still like to do that if we can, the requirement to run recovery and/or use xfs-specific mount options to get a snapshot mounted is still a weird wart. Pretty sure I've seen at least one user who thought we completely failed to generate consistent snapshots because "the log was dirty" and "I had to run repair." So it'd still be nice to get rid of that behavior IMHO. -Eric
