On Wed, Dec 09, 2020 at 11:22:37AM +0100, Christoph Hellwig wrote: > On Wed, Dec 09, 2020 at 04:43:42PM +0800, Gao Xiang wrote: > > Yeah, so maybe I should revert back to the old code? not sure... Anyway, > > I think codebase could be changed over time from a single change. Anyway, > > I'm fine with either way. So I may hear your perference about this and send > > out the next version (I think such cleanup can be fited in 5.11, so I can > > base on this and do more work....) > > Personally I'd prefer to just use the errno return and ipp by reference > calling convention for the newly added helper as well. But I'm ok with > all variants, so maybe I should add my: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > here in case Darrick wants to pick this up. > > Looking at idmapped mounts series it would really help to get this in > ASAP to avoid conflicts. Ok, let me send out a quick next version to get rid of that inlined comment mentioned earlier. Thanks, Gao Xiang >
