On Mon, Dec 07, 2020 at 02:57:19PM +0100, Christoph Hellwig wrote:
> > + error = xfs_ialloc_ag_alloc(*tpp, agbp);
> > + if (error < 0) {
> > xfs_trans_brelse(*tpp, agbp);
> >
> > if (error == -ENOSPC)
> > error = 0;
> > break;
> > + } else if (error == 0) {
>
> No need for the else after the break.
Personally, I'd like to save a line by using "} else if {"
for such case (and tell readers about these two judgments),
and for any cases, compilers will do their best.
Yet, if you like, I could add an extra line for this.
Will update in the next version.
Thanks,
Gao Xiang
>
