On Fri, Dec 04, 2020 at 02:35:45PM -0600, Eric Sandeen wrote: > On 11/30/20 9:37 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > A couple of the superblock validation checks apply only to the kernel, > > so move them to xfs_mount.c before we start changing sb_inprogress. > > This also reduces the diff between kernel and userspace libxfs. > > My only complaint is that "xfs_sb_validate_mount" isn't really descriptive > at all, and nobody reading the code or comments will know why we've chosen > to move just these two checks out of the common validator... > > What does "compatible with this mount" mean? Compatible with this implementation? > Maybe just fess up in the comment, and say "these checks are different > for kernel vs. userspace so we keep them over here" - and as for the > function name, *shrug* not sure I have anything better... _validate_implementation? I don't have a better suggestion either. --D > -Eric >
