On Thu, Dec 03, 2020 at 05:13:02PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > It's possible that xfs_iget can return EINVAL for inodes that the inobt > thinks are free, or ENOENT for inodes that look free. If this is the > case, mark the directory corrupt immediately when we check ftype. Note > that we already check the ftype of the '.' and '..' entries, so we > can skip the iget part since we already know the inode type for '.' and > we have a separate parent pointer scrubber for '..'. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> But I wonder if we need the EINVAL vs ENOENT distinction to start with or if we could return a single coherent error code from iget.
