Hi Dave, On Fri, Dec 04, 2020 at 07:31:30AM +1100, Dave Chinner wrote: > On Fri, Dec 04, 2020 at 12:10:25AM +0800, Gao Xiang wrote: ... > > - * directly to the superblock - and so have no parent. > > + * Initialise a newly allocated inode and return the in-core inode to the > > + * caller locked exclusively. > > */ > > -static int > > +static struct xfs_inode * > > xfs_ialloc( > > Can we rename this xfs_dir_ialloc_init()? > > That way we keep everything in xfs_inode.c under the same namespace > (xfs_dir_ialloc_*) and don't confuse it with functions in the > xfs_ialloc_* namespace in fs/xfs/libxfs/xfs_ialloc*.c... Ok, thanks for the suggestion! Let me revise it in the next version. Thanks, Gao Xiang > > Otherwise looks good. > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx >
