On Wed, Dec 02, 2020 at 05:15:30PM +0000, Christoph Hellwig wrote: > On Wed, Dec 02, 2020 at 08:44:24AM -0600, Eric Sandeen wrote: > > Would it be correct to restate your last sentence as "Disallowing reflink > > when XFS_DIFLAG2_DAX is set and dax=inode is set makes sense?" > > > > If so, then the only change you're suggesting to this patch is to /allow/ > > reflinking if dax=never is set? > > Yes, I think we should. > > > I just figured a very clear statementa bout incompatible flags was simplest, > > but I get it that it's overly restrictive, functionally. > > The simplest in terms of semantics is to make sure reflink+DAX works, > and while we are on the way we'll still need a workaround until that > happen. happens.