On Tue, Dec 01, 2020 at 10:21:00AM +0000, Christoph Hellwig wrote: > On Tue, Nov 24, 2020 at 11:51:29PM +0800, Gao Xiang wrote: > > It's enough to just use return code, and get rid of an argument. > > > > Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx> > > --- > > fs/xfs/libxfs/xfs_ialloc.c | 22 ++++++++++------------ > > 1 file changed, 10 insertions(+), 12 deletions(-) > > > > diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c > > index 45cf7e55f5ee..5c8b0210aad3 100644 > > --- a/fs/xfs/libxfs/xfs_ialloc.c > > +++ b/fs/xfs/libxfs/xfs_ialloc.c > > @@ -607,13 +607,14 @@ xfs_inobt_insert_sprec( > > > > /* > > * Allocate new inodes in the allocation group specified by agbp. > > - * Return 0 for success, else error code. > > + * Return 0 for successfully allocating some inodes in this AG; > > + * 1 for skipping to allocating in the next AG; > > s/for/when/ for both lines I think. > > > + * < 0 for error code. > > and < 0 for errors here maybe. But I'm not a native speaker either. "Returns 0 if inodes were allocated in this AG; 1 if there was no space in this AG; or the usual negative error code." ? --D > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
