On 11/23/20 12:36 PM, Eric Sandeen wrote: > On 11/23/20 3:38 AM, xiakaixu1987@xxxxxxxxx wrote: >> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx> >> >> The quota option 'usrquota' should be shown if both the XFS_UQUOTA_ACCT >> and XFS_UQUOTA_ENFD flags are set. The option 'uqnoenforce' should be >> shown when only the XFS_UQUOTA_ACCT flag is set. The current code logic >> seems wrong, Fix it and show proper options. > > I'm failing to see the difference in the logic here. Under the current > code, what combination of flags yields the wrong string, and what does > this patch change in that respect? <djwong pointed out what I missed> But I guess that just emphasizes the need for a test :) Thanks, -Eric