On 11/19/20 7:05 PM, Darrick J. Wong wrote: > On Wed, Nov 18, 2020 at 03:05:42PM -0600, Eric Sandeen wrote: ... >> so this seems to have exposed a hole in how repair deals with unknown features >> when the inprogress bit is set. >> >> And TBH scampering off to find backup superblocks to "repair" an inprogress >> filesystem seems like ... not the right thing to do after a feature upgrade. >> >> I'm not sure what's better, but >> >>> bad primary superblock - filesystem mkfs-in-progress bit set !!! >> >> seems ... unexpected for this purpose. > > Yeah. Dave suggested that I use an incompat flag for this, so I think > I'll do that instead since inprogress is such a mess. And I'll try to get to validating V5 features earlier in the repair cycle ... -Eric
