On Tue, Nov 10, 2020 at 04:44:49PM -0800, Darrick J. Wong wrote: > aval = malloc(len); > memset(aval, nameseq & 0xff, len); > - e = attr_set_path(&f, aname, aval, len, ATTR_DONTFOLLOW) < 0 ? > + e = attr_set_path(&f, aname, aval, len) < 0 ? > errno : 0; Nipick, but I'd spell this out in a normal if while you touch it: if (attr_set_path(&f, aname, aval, len) < 0) e = errno; else e = 0; Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>