Hi Linus, The bug fix in the vfs pull request that I just sent you makes __sb_start_write simple enough that it becomes possible to refactor the function into smaller, simpler static inline helpers in linux/fs.h. The cleanup is straightforward, but as we're well into the stabilization phase for 5.10, I'm perfectly happy to defer this to 5.11. These changes also merge cleanly with upstream as of a few minutes ago, so please let me know if anything strange happens. --D The following changes since commit 22843291efc986ce7722610073fcf85a39b4cb13: vfs: remove lockdep bogosity in __sb_start_write (2020-11-10 16:49:29 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/vfs-5.10-fixes-2 for you to fetch changes up to 9b8523423b23ee3dfd88e32f5b7207be56a4e782: vfs: move __sb_{start,end}_write* to fs.h (2020-11-10 16:53:11 -0800) ---------------------------------------------------------------- More VFS fixes for 5.10-rc4: - Minor cleanups of the sb_start_* fs freeze helpers. ---------------------------------------------------------------- Darrick J. Wong (2): vfs: separate __sb_start_write into blocking and non-blocking helpers vfs: move __sb_{start,end}_write* to fs.h fs/aio.c | 2 +- fs/io_uring.c | 3 +-- fs/super.c | 24 ------------------------ include/linux/fs.h | 38 +++++++++++++++++++++++++++----------- 4 files changed, 29 insertions(+), 38 deletions(-)