On Mon, Nov 09, 2020 at 10:17:39AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Fix some serious WTF in the reference count scrubber's rmap fragment
> processing. The code comment says that this loop is supposed to move
> all fragment records starting at or before bno onto the worklist, but
> there's no obvious reason why nr (the number of items added) should
> increment starting from 1, and breaking the loop when we've added the
> target number seems dubious since we could have more rmap fragments that
> should have been added to the worklist.
>
> This seems to manifest in xfs/411 when adding one to the refcount field.
>
> Fixes: dbde19da9637 ("xfs: cross-reference the rmapbt data with the refcountbt")
Looks good,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
