On Tue, Nov 03, 2020 at 10:34:44AM -0800, Darrick J. Wong wrote: > > Please split the function into __sb_start_write and > > __sb_start_write_trylock while you're at it.. > > Any thoughts on this patch itself? I don't feel like I have 100% of the > context to know whether the removal is a good idea for non-xfs > filesystems, though I'm fairly sure the current logic is broken. The existing logic looks pretty bogus to me as well. Did you try to find the discussion that lead to it?