On Thu, Oct 29, 2020 at 10:25:57AM -0700, Darrick J. Wong wrote: > On Thu, Oct 29, 2020 at 09:45:49AM +0000, Christoph Hellwig wrote: > > On Thu, Oct 29, 2020 at 09:45:04AM +0000, Christoph Hellwig wrote: > > > Looks good, > > > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > > > And no good reason to use struct timespec64 here, right? > > Huh? There's no mention of a timespec in this patch at all...? No, but a few patches earlier timespec64 is added with the rationale that we can't rely on a 64-bit time type otherwise, while we use time64_t here.