On 2020/10/15 16:22, Christoph Hellwig wrote: > On Sat, Oct 10, 2020 at 10:54:19AM +0800, xiakaixu1987@xxxxxxxxx wrote: >> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx> >> >> The function xfs_trans_mod_dquot_byino() wrap around xfs_trans_mod_dquot() > > s/wrap/wraps/ > > Also this line is too long for commit messages. > >> >> to account for quotas, and also there is the function call chain >> xfs_trans_reserve_quota_bydquots -> xfs_trans_dqresv -> xfs_trans_mod_dquot, > > This one as well. Yeah, I'll fix them in the next version. Thanks, Kaixu > > Otherwise this looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > -- kaixuxia