> + xfs_trans_mod_dquot(tp, dqp, > + flags & XFS_QMOPT_RESBLK_MASK, > + nblks); > + xfs_trans_mod_dquot(tp, dqp, > + XFS_TRANS_DQ_RES_INOS, > + ninos); This can be shortened to: xfs_trans_mod_dquot(tp, dqp, flags & XFS_QMOPT_RESBLK_MASK, nblk); xfs_trans_mod_dquot(tp, dqp, XFS_TRANS_DQ_RES_INOS, ninos); Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>