Re: [PATCH v9 4/4] xfs: replace mrlock_t with rw_semaphores

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Hi,
>>
>> thanks for the comments, however for some reason I cannot reproduce
>> the same memory corruption you are getting.
> 
> <shrug> Do you have full preempt enabled?

Hi, I'm not proud to admit that until now I tested w/o 'CONFIG_PREEMPT=y' :-/
However at least now I can see the bug you hit and test that the proposed change in version #10 fixes that.


> 
>> Do you think that moving the 'rwsem_release()' right before the
>> 'complete()' should fix the problem?
>>
>> Something like:
>>
>>
>> +       /*
>> +        * Update lockdep's lock ownership information to point to
>> +        * this thread as the thread that scheduled this worker is waiting
>> +        * for it's completion.
> 
> Nit: "it's" is always a contraction of "it is"; "its" is correct
> (posessive) form here.

Thanks for noticing. I know the difference...but still I did this mistake. I must focus more next time.

> 
> Otherwise, this looks fine to me.

Thanks, version #10 is on list now.

Bye.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux