From: Gao Xiang <hsiangkao@xxxxxxxxxx> Hi, v3: https://lore.kernel.org/r/20200806130301.27937-1-hsiangkao@xxxxxxxxxx This is another approach suggested by Eric in the reply of v3 (if I understand correctly), which also attempts to use i18n-enabled xfsprogs xfs_notice() to error out sanity check failure suggested by Dave on IRC. In addition, I manually ported [PATCH 2/3] to the kernel side as well then fault injection with xfs_db and it seems work as expected. Thanks, Gao Xiang changes since v3: - mainly follow Eric suggestion mentioned in the reply of v3, e.g directly prints the error using xfs_notice/warn() and return bool; - with an exception that it doesn't need the unit of sunit/swidth are in bytes if sectorsize is not specified, since the sanity check logic condition only needs these are in the same unit, so it saves calculation for these FSB / sector-based representation. Gao Xiang (3): xfsprogs: allow i18n to xfs printk xfs: introduce xfs_validate_stripe_factors() xfsprogs: make use of xfs_validate_stripe_factors() libxfs/libxfs_priv.h | 8 +++---- libxfs/xfs_sb.c | 54 +++++++++++++++++++++++++++++++++++--------- libxfs/xfs_sb.h | 3 +++ mkfs/xfs_mkfs.c | 23 ++++++------------- 4 files changed, 57 insertions(+), 31 deletions(-) -- 2.24.0
