On Thu, Oct 01, 2020 at 09:20:15PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > When xfs_defer_capture extracts the deferred ops and transaction state > from a transaction, it should record the remaining block reservations so > that when we continue the dfops chain, we can reserve the same number of > blocks to use. We capture the reservations for both data and realtime > volumes. > > This adds the requirement that every log intent item recovery function > must be careful to reserve enough blocks to handle both itself and all > defer ops that it can queue. On the other hand, this enables us to do > away with the handwaving block estimation nonsense that was going on in > xlog_finish_defer_ops. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> I like this version better as well: Reviewed-by: Christoph Hellwig <hch@xxxxxx>