Re: [PATCH v2] libxfs: disallow filesystems with reverse mapping and reflink and realtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/30/20 11:19 AM, Darrick J. Wong wrote:
> On Wed, Sep 30, 2020 at 11:09:29AM -0500, Eric Sandeen wrote:
>> On 9/30/20 11:01 AM, Darrick J. Wong wrote:
>>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>>>
>>> Neither the kernel nor the code in xfsprogs support filesystems that
>>> have (either reverse mapping btrees or reflink) enabled and a realtime
>>> volume configured.  The kernel rejects such combinations and mkfs
>>> refuses to format such a config, but xfsprogs doesn't check and can do
>>> Bad Things, so port those checks before someone shreds their filesystem.
>>>
>>> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>>
>>
>> so now xfs_db won't even touch it, I'm not sure that's desirable.
>>
>> # db/xfs_db fsfile
>> xfs_db: Reflink not compatible with realtime device. Please try a newer xfsprogs.
>> xfs_db: realtime device init failed
>> xfs_db: device fsfile unusable (not an XFS filesystem?)
> 
> Er... did you specially craft fsfile to have rblocks>0 and reflink=1?
> Or are you saying that it rejects any reflink=1 filesystem now?

crafted.  sorry didn't mean to scare you ;)

-Eric




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux