On 8/24/20 3:37 PM, Anthony Iliopoulos wrote:
> rmapbt and reflink are incompatible with realtime devices and mkfs bails
> out on such configurations. Switching them off in the cli params after
> exit is dead code, remove it.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx>
I'll go ahead & pull patches 5 & 6 since they're standalone fixes.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> mkfs/xfs_mkfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 75e910dd4a30..1f142f78e677 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -1995,14 +1995,12 @@ _("cowextsize not supported without reflink support\n"));
> fprintf(stderr,
> _("reflink not supported with realtime devices\n"));
> usage();
> - cli->sb_feat.reflink = false;
> }
>
> if (cli->sb_feat.rmapbt && cli->xi->rtname) {
> fprintf(stderr,
> _("rmapbt not supported with realtime devices\n"));
> usage();
> - cli->sb_feat.rmapbt = false;
> }
>
> if (cli->sb_feat.reflink && ft->dax) {
>
