On Mon, Sep 28, 2020 at 08:20:34AM +0200, Christoph Hellwig wrote: > On Sun, Sep 27, 2020 at 04:41:14PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Remove this one-line helper. > > Maybe expand the rationale here a little more? I'll change it to: "Remove this one-line helper since the assert is trivially true in one call site and the rest just obscures a bitmask operation." --D > Otherwise looks fine: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
