On Thu, Sep 17, 2020 at 07:19:40PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Nowadays, log recovery will call ->release on the recovered intent items > if recovery fails. Therefore, it's redundant to release them from > inside the ->recover functions when they're about to return an error. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > v3: fix subject line > v2: log recovery frees unfinished intent items on failure, so remove > release calls > --- > fs/xfs/xfs_bmap_item.c | 12 ++---------- > fs/xfs/xfs_extfree_item.c | 8 +------- > fs/xfs/xfs_refcount_item.c | 8 +------- > fs/xfs/xfs_rmap_item.c | 8 +------- > 4 files changed, 5 insertions(+), 31 deletions(-) looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
