Re: [PATCH 1/2] xfs: refactor inode flags propagation code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +		if (pip && (pip->i_d.di_flags & XFS_DIFLAG_ANY))
> +			xfs_inode_propagate_flags(ip, pip);
> +		if (pip && (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY))
> +			xfs_inode_propagate_flags2(ip, pip);

I'd further simplify this to:

		if (pip) {
			if (pip->i_d.di_flags & XFS_DIFLAG_ANY)
				xfs_inode_propagate_flags(ip, pip);
			if (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY)
				xfs_inode_propagate_flags2(ip, pip);
		}

and maybe use "inherit" instead of "propagate"

But otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux