> + if (pip && (pip->i_d.di_flags & XFS_DIFLAG_ANY)) > + xfs_inode_propagate_flags(ip, pip); > + if (pip && (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY)) > + xfs_inode_propagate_flags2(ip, pip); I'd further simplify this to: if (pip) { if (pip->i_d.di_flags & XFS_DIFLAG_ANY) xfs_inode_propagate_flags(ip, pip); if (pip->i_d.di_flags2 & XFS_DIFLAG2_ANY) xfs_inode_propagate_flags2(ip, pip); } and maybe use "inherit" instead of "propagate" But otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>