On Mon, Sep 07, 2020 at 10:51:49AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > mkfs has some logic to deal with situations where reflink or rmapbt are > turned on and the administrator has configured a realtime device or a V4 > filesystem; such configurations are not allowed. > > The logic ought to disable reflink and/or rmapbt if they're enabled due > to being the defaults, and it ought to complain and abort if they're > enabled because the admin explicitly turned them on. > > Unfortunately, the logic here doesn't do that and makes no sense at all > since usage() exits the program. Fix it to follow what everything else > does. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>
