> >
> > +/* total space in use */
>
> Comment is redundant.
>
> > +static inline int xfs_attr_sf_totsize(struct xfs_inode *dp)
> > +{
> > + struct xfs_attr_shortform *sf =
> > + (struct xfs_attr_shortform *)dp->i_afp->if_u1.if_data;
> > +
> > + return be16_to_cpu(sf->hdr.totsize);
> > +}
>
> If you have to break the declaration line like that, you
> may as well just do:
>
> + struct xfs_attr_shortform *sf;
> +
> + sf = (struct xfs_attr_shortform *)dp->i_afp->if_u1.if_data;
> + return be16_to_cpu(sf->hdr.totsize);
>
>
> Otherwise the patch looks fine.
>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Fair enough, I'll re-send this patch, thanks for the review guys.
>
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
>
--
Carlos
