On Tue, Sep 01, 2020 at 08:23:59AM -0700, Darrick J. Wong wrote: > > FWIW, I thought we tried to avoid including headers from other headers > > like this. I'm also wondering if it's an issue that we'd be including a > > a header that is external to libxfs from a libxfs header. Perhaps this > > could be simplified by passing the xfs_ifork pointer to the new helper > > rather than the xfs_inode and/or moving the helper to > > libxfs/xfs_inode_fork.h and putting a forward declaration of > > xfs_attr_shortform in there..? > > If you change if_data to a (void *), all the casts become unnecessary, > right? Yes, that is probably an even better idea.
