On Tue, Sep 01, 2020 at 10:02:49AM -0700, Darrick J. Wong wrote: > On Tue, Sep 01, 2020 at 05:50:18PM +0200, Christoph Hellwig wrote: > > Instead of poking deeply into buffer cache internals when re-reading the > > superblock during log recovery just generalize _xfs_buf_read and use it > > there. Note that we don't have to explicitly set up the ops as they > > must be set from the initial read. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > /me isn't too thrilled by the forward declaration of __xfs_buf_submit > but oh well. :) Im neither, but getting rid of that would required a major rearrangement of xfs_buf.c.
