On Sun, Aug 30, 2020 at 11:07:26PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Redefine xfs_timestamp_t as a __be64 typedef in preparation for the > bigtime functionality. Preserve the legacy structure format so that we > can let the compiler take care of masking and shifting. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Reviewed-by: Gao Xiang <hsiangkao@xxxxxxxxxx> (Although I preferr something like (untested), struct timespec64 xfs_inode_from_disk_ts( const xfs_timestamp_t ts) { struct xfs_legacy_timestamp *lts = (void *)&ts; return (struct timespec64) { .tv_sec = (int64_t)be32_to_cpu(lts->t_sec), .tv_nsec = (int)be32_to_cpu(lts->t_nsec) }; } and similiar to xfs_log_dinode_to_disk_ts()... that's quite minor...) Thanks, Gao Xiang