Re: [PATCH] mkfs.xfs: remove comment about needed future work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 27, 2020 at 02:37:17PM -0500, Eric Sandeen wrote:
> Remove comment about the need to sync this function with the
> kernel; that was mostly taken care of with:
> 
> 7b7548052 ("mkfs: use libxfs to write out new AGs")
> 
> There's maybe a little more samey-samey that we could do here,
> but it's not egregiously cut & pasted as it was before.
> 
> Signed-off-by: Eric Sandeen <sandeen2redhat.com>

Fixes: 7b7548052d12 ("mkfs: use libxfs to write out new AGs")
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index a687f385..874e40da 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3418,11 +3418,6 @@ prepare_devices(
>  
>  }
>  
> -/*
> - * XXX: this code is mostly common with the kernel growfs code.
> - * These initialisations should be pulled into libxfs to keep the
> - * kernel/userspace header initialisation code the same.
> - */
>  static void
>  initialise_ag_headers(
>  	struct mkfs_params	*cfg,
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux