On Thu, Aug 27, 2020 at 08:00:50AM +0100, Christoph Hellwig wrote: > > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h > > index 972c740aaf7b..9cf84b57e2ce 100644 > > --- a/fs/xfs/libxfs/xfs_format.h > > +++ b/fs/xfs/libxfs/xfs_format.h > > @@ -1257,13 +1257,15 @@ static inline bool xfs_dinode_has_bigtime(const struct xfs_dinode *dip) > > #define XFS_DQTYPE_USER 0x01 /* user dquot record */ > > #define XFS_DQTYPE_PROJ 0x02 /* project dquot record */ > > #define XFS_DQTYPE_GROUP 0x04 /* group dquot record */ > > +#define XFS_DQTYPE_BIGTIME 0x08 /* large expiry timestamps */ > > Maybe make this the high bit in the field to keep space for adding more > actual quota types if we need them? Ok. 0x80 it is. --D > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>