On Thu, Aug 27, 2020 at 11:18 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > On Thu, Aug 27, 2020 at 11:17:34AM +0300, Amir Goldstein wrote: > > Looking at this my eyes pop out. > > I realize that maintaining on-disk format of the log is challenging, > > so if there is no other technical solution that will be easier for humans > > to review and maintain going forward, I will step back and let others > > review this code. > > > > But it bears the question: do we have to support replaying on BE a > > log that was recorded on LE? Especially with so little BE machines > > around these days, this sounds like over design to me. > > Wouldn't it be better just to keep a bit in the log if it is LE or BE and refuse > > to replay it on the wrong architecture? > > XFS has never supported replaying a BE log on LE machine or vice versa. Right. Makes sense. I guess I read this backwards: https://lore.kernel.org/linux-xfs/20200825003945.GA6096@magnolia/T/#u Sorry for the noise. Thanks, Amir.
