On Tue, Aug 25, 2020 at 03:48:13PM -0500, Eric Sandeen wrote: > On 8/25/20 3:28 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > Don't leak kernel memory contents into the shortform attr fork. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > I noticed this too, thanks. > > thought I wonder if > > a) others lurk and > b) if we should just be memsetting if_data to zero to avoid the need > to carefully initialize all of everything always? > > Anyway it fixes the problem we noticed so Yes, I think fully clearing the thing would be better. We can do a memset for now, but splitting the non-existent data case out of xfs_idata_realloc into a new helper that does kzmalloc sounds best long term.
