On Wed, Aug 26, 2020 at 04:56:34PM -0500, Eric Sandeen wrote: > On 8/25/20 8:56 PM, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Add the framework that will allow the config file to be supplied on > > the CLI and passed to the library that will parse it. This does not > > yet do any option parsing from the config file. > > so we have "-c $SUBOPT=file" > > From what I read in the cover letter, and from checking in IRC it seems > like you envision the ability to also specify defaults from a config file > in the future; to that end it might be better to name this $SUBOPT > "options=" instead of "file=" as the latter is very generic. > > Then in the future, we could have one or both of : > > -c defaults=file1 -c options=file2 > > i.e. configure the defaults, then configure the options Yup, makes sense. Will change. > I guess this is just RFC but you want probably to drop the "Ini debug:" > printf eventually. Yeah, I've already removed that so I can run fstests.... > This will need a man page update, of course. Eventually, yes :P > I think it should explain where "file" will be looked for; I assume it > is either a full path, or a relative path to the current directory. It will work with either, just like all the other "file" parameters passed to mkfs.... > (In the future it would be nice to have mkfs.xfs search somewhere > under /etc for these files as well, but I'm not bikeshedding!) Nope, I'm not doing that. Go away. :) Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
