On 8/26/20 11:44 AM, Darrick J. Wong wrote: > On Wed, Aug 26, 2020 at 11:19:54AM -0500, Eric Sandeen wrote: >> The boundary test for the fixed-offset parts of xfs_attr_sf_entry in >> xfs_attr_shortform_verify is off by one, because the variable array >> at the end is defined as nameval[1] not nameval[]. >> Hence we need to subtract 1 from the calculation. >> >> This can be shown by: >> >> # touch file >> # setfattr -n root.a file >> >> and verifications will fail when it's written to disk. >> >> This only matters for a last attribute which has a single-byte name >> and no value, otherwise the combination of namelen & valuelen will >> push endp further out and this test won't fail. >> >> Fixes: 1e1bbd8e7ee06 ("xfs: create structure verifier function for shortform xattrs") >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Looks ok. thanks > From whom should I be expecting a test case? from me or a TBD delegate. Will follow up soon. -Eric > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>