On Sat, Aug 22, 2020 at 08:33:56AM +0100, Christoph Hellwig wrote: > > +/* Convert an on-disk timer value into an incore timer value. */ > > +void > > +xfs_dquot_from_disk_timestamp( > > + struct xfs_disk_dquot *ddq, > > + time64_t *timer, > > + __be32 dtimer) > > +{ > > + *timer = be32_to_cpu(dtimer); > > +} > > + > > +/* Convert an incore timer value into an on-disk timer value. */ > > +void > > +xfs_dquot_to_disk_timestamp( > > + struct xfs_dquot *dqp, > > + __be32 *dtimer, > > + time64_t timer) > > +{ > > + *dtimer = cpu_to_be32(timer); > > Why not return the values? I'll fix those return vlaues too. --D