While looking to find how this is used, I noticed that it only starts to get used in patch 12. Maybe move it just before that to help the reviewers keep context? > + struct xfs_log_item *lia = container_of(a, > + struct xfs_log_item, li_trans); > + struct xfs_log_item *lib = container_of(b, > + struct xfs_log_item, li_trans); lib as a variable name reads a little strange :) What about li1 and li2?
