On Thu, Aug 20, 2020 at 07:12:02PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Move this function to xfs_inode_item.c to match the encoding function > that's already there. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> An good reason to not move it towards its only caller in fs/xfs/xfs_inode_item_recover.c?