On Thu, Aug 20, 2020 at 07:05:37PM -0500, Eric Sandeen wrote:
> There's no reason to go through the type change code if the
> type has not been changed.
>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> diff --git a/db/type.c b/db/type.c
> index 3cb1e868..572ac6d6 100644
> --- a/db/type.c
> +++ b/db/type.c
> @@ -216,6 +216,8 @@ type_f(
> tt = findtyp(argv[1]);
> if (tt == NULL) {
> dbprintf(_("no such type %s\n"), argv[1]);
> + } else if (iocur_top->typ == tt) {
> + return 0;
Doesn't this mean that verifier errors won't be printed if the user asks
to set the type to the current type? e.g.
xfs_db> agf 0
xfs_db> addr bnoroot
xfs_db> fuzz -d level random
Allowing fuzz of corrupted data with good CRC
level = 59679
xfs_db> type bnobt
Metadata corruption detected at 0x5586779a7b18, xfs_bnobt block 0x8/0x1000
xfs_db> type bnobt
Metadata corruption detected at 0x5586779a7b18, xfs_bnobt block 0x8/0x1000
<shrug> OTOH, db doesn't consistently have that behavior either --
inodes only behave like that for crc errors, so maybe this is fine.
Eh whatever, it's the debugging tool, you should be paying attention
anyways.
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
--D
> } else {
> if (iocur_top->typ == NULL)
> dbprintf(_("no current object\n"));
>
