On Tue, Aug 18, 2020 at 11:17:45AM -0700, Darrick J. Wong wrote: > On Wed, Aug 12, 2020 at 07:25:43PM +1000, Dave Chinner wrote: > > Hi folks, > > > > This is a cleaned up version of the original RFC I posted here: > > > > https://lore.kernel.org/linux-xfs/20200623095015.1934171-1-david@xxxxxxxxxxxxx/ > > > > The original description is preserved below for quick reference, > > I'll just walk though the changes in this version: > > > > - rebased on current TOT and xfs/for-next > > - split up into many smaller patches > > - includes Xiang's single unlinked list bucket modification > > - uses a list_head for the in memory double unlinked inode list > > rather than aginos and lockless inode lookups > > - much simpler as it doesn't need to look up inodes from agino > > values > > - iunlink log item changed to take an xfs_inode pointer rather than > > an imap and agino values > > - a handful of small cleanups that breaking up into small patches > > allowed. > > Two questions: How does this patchset intersect with the other one that > changes the iunlink series? I guess the v4 of that series (when it > appears) is intended to be applied directly after this one? *nod* > The second is that I got this corruption warning on generic/043 with... I haven't seen that. I'll see if I can reproduce it. > FSTYP -- xfs (debug) > PLATFORM -- Linux/x86_64 ca-nfsdev6-mtr01 5.9.0-rc1-djw #rc1 SMP PREEMPT Mon Aug 17 20:13:04 PDT 2020 > MKFS_OPTIONS -- -f -m reflink=1,rmapbt=1 -i sparse=1, -b size=1024, /dev/sdd > MOUNT_OPTIONS -- -o usrquota,grpquota,prjquota, /dev/sdd /opt > > [16533.664277] run fstests generic/043 at 2020-08-18 00:50:48 I've run that config through fstests, too. I'll go run this test in a loop, see if I can trigger it... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
