On Fri, Jul 24, 2020 at 03:31:30PM +1000, Dave Chinner wrote:
> On Thu, Jul 23, 2020 at 08:46:28PM -0700, Eric Biggers wrote:
> > On Fri, Jul 24, 2020 at 11:39:10AM +1000, Dave Chinner wrote:
> > > fscrypt_inode_uses_inline_crypto() ends up being:
> > >
> > > if (IS_ENCRYPTED(inode) && S_ISREG(inode->i_mode) &&
> > > inode->i_crypt_info->ci_inlinecrypt)
> > >
> > > I note there are no checks for inode->i_crypt_info being non-null,
> > > and I note that S_ENCRYPTED is set on the inode when the on-disk
> > > encrypted flag is encountered, not when inode->i_crypt_info is set.
> > >
> >
> > ->i_crypt_info is set when the file is opened, so it's guaranteed to be set for
> > any I/O. So the case you're concerned about just doesn't happen.
>
> Ok. The connection is not obvious to someone who doesn't know the
> fscrypt code inside out.
>
> > > > Note that currently, I don't think iomap_dio_bio_actor() would handle an
> > > > encrypted file with blocksize > PAGE_SIZE correctly, as the I/O could be split
> > > > in the middle of a filesystem block (even after the filesystem ensures that
> > > > direct I/O on encrypted files is fully filesystem-block-aligned, which we do ---
> > > > see the rest of this patchset), which isn't allowed on encrypted files.
> > >
> > > That can already happen unless you've specifically restricted DIO
> > > alignments in the filesystem code. i.e. Direct IO already supports
> > > sub-block ranges and alignment, and we can already do user DIO on
> > > sub-block, sector aligned ranges just fine. And the filesystem can
> > > already split the iomap on sub-block alignments and ranges if it
> > > needs to because the iomap uses byte range addressing, not sector or
> > > block based addressing.
> > >
> > > So either you already have a situation where the 2^32 offset can
> > > land *inside* a filesystem block, or the offset is guaranteed to be
> > > filesystem block aligned and so you'll never get this "break an IO
> > > on sub-block alignment" problem regardless of the filesystem block
> > > size...
> > >
> > > Either way, it's not an iomap problem - it's a filesystem mapping
> > > problem...
> > >
> >
> > I think you're missing the point here. Currently, the granularity of encryption
> > (a.k.a. "data unit size") is always filesystem blocks, so that's the minimum we
> > can directly read or write to an encrypted file. This has nothing to do with
> > the IV wraparound case also being discussed.
>
> So when you change the subject, please make it *really obvious* so
> that people don't think you are still talking about the same issue.
>
> > For example, changing a single bit in the plaintext of a filesystem block may
> > result in the entire block's ciphertext changing. (The exact behavior depends
> > on the cryptographic algorithm that is used.)
> >
> > That's why this patchset makes ext4 only allow direct I/O on encrypted files if
> > the I/O is fully filesystem-block-aligned. Note that this might be a more
> > strict alignment requirement than the bdev_logical_block_size().
> >
> > As long as the iomap code only issues filesystem-block-aligned bios, *given
> > fully filesystem-block-aligned inputs*, we're fine. That appears to be the case
> > currently.
>
> The actual size and shape of the bios issued by direct IO (both old
> code and newer iomap code) is determined by the user supplied iov,
> the size of the biovec array allocated in the bio, and the IO
> constraints of the underlying hardware. Hence direct IO does not
> guarantee alignment to anything larger than the underlying block
> device logical sector size because there's no guarantee when or
> where a bio will fill up.
>
> To guarantee alignment of what ends up at the hardware, you have to
> set the block device parameters (e.g. logical sector size)
> appropriately all the way down the stack. You also need to ensure
> that the filesystem is correctly aligned on the block device so that
> filesystem blocks don't overlap things like RAID stripe boundaires,
> linear concat boundaries, etc.
>
> IOWs, to constrain alignment in the IO path, you need to configure
> you system correct so that the information provided to iomap for IO
> alignment matches your requirements. This is not somethign iomap can
> do itself; everything from above needs to be constrained by the
> filesystem using iomap, everything sent below by iomap is
> constrained by the block device config.
That way of thinking about things doesn't entirely work for inline encryption.
Hardware can support multiple encryption "data unit sizes", some of which may be
larger than the logical block size. (The data unit size is the granularity of
encryption. E.g. if software selects data_unit_size=4096, then each invocation
of the encryption/decryption algorithm is passed 4096 bytes. You can't then
later encrypt/decrypt just part of that; that's not how the algorithms work.)
For example hardware might *in general* support addressing 512-byte sectors and
thus have logical_block_size=512. But it could also support encryption data
unit sizes [512, 1024, 2048, 4096]. Encrypted I/O has to be aligned to the data
unit size, not just to the logical block size. The data unit size to use, and
whether to use encryption or not, is decided on a per-I/O basis.
So in this case technically it's the filesystem (and later the
bio::bi_crypt_context which the filesystem sets) that knows about the alignment
needed -- *not* the request_queue.
Is it your opinion that inline encryption should only be supported when
data_unit_size <= logical_block_size? The problems with that are
(a) Using an unnecessarily small data_unit_size degrades performance a
lot -- for *all* I/O, not just direct I/O. This is because there are a
lot more separate encryptions/decryptions to do, and there's a fixed
overhead to each one (much of which is intrinsic in the crypto
algorithms themselves, i.e. this isn't simply an implementation quirk).
(b) fscrypt currently only supports data_unit_size == filesystem_block_size.
(OFC, filesystem_block_size may be greater than logical_block_size.)
(c) Filesystem images would be less portable, unless the minimum
data_unit_size were used everywhere which would degrade performance.
(We could address (b) by allowing users to specify data_unit_size when
encrypting a directory. That would add complexity, but it's possible.)
But again, as far as I can tell, fs/iomap/direct-io.c currently *does* guarantee
that *if* the input is fully filesystem-block-aligned and if blocksize <=
PAGE_SIZE, then the issued I/O is also filesystem-block-aligned.
So as far as I can tell, there isn't really any problem there, at least not now.
I just want to make sure we're on the same page...
>
> > (It's possible that in the future we'll support other encryption data unit
> > sizes, perhaps powers of 2 from 512 to filesystem block size. But for now the
> > filesystem block size has been good enough for everyone,
>
> Not the case. fscrypt use in enterprise environments needs support
> for block size < page size so that it can be deployed on 64kB page
> size machines without requiring 64kB filesystem block sizes.
>
It's already supported (on ext4 since Linux v5.5).
What's not supported (yet) is data_unit_size < filesystem_block_size.
- Eric
