On Wed, Jul 15, 2020 at 10:08:35AM -0400, Brian Foster wrote: > If a directory inode has an invalid parent ino on disk, repair > replaces the invalid value with a dummy value of zero in the buffer > and NULLFSINO in the in-core parent tracking. The zero value serves > no functional purpose as it is still an invalid value and the parent > must be repaired by phase 6 based on the in-core state before the > buffer can be written out. Instead, use the root fs inode number as > a catch all for invalid parent values so phase 6 doesn't have to > create custom verifier infrastructure just to work around this > behavior. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Reasonale, but wouldn't it be better to use lost+found as the dummy parent inode (i.e. the orphanage inode)? Because if the parent can't be found and the inode reconnected correctly, we're going to put it in lost+found, anyway? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
