On Tue, Jul 14, 2020 at 02:46:25PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> If the filesystem looks like it had up to date quota information, check
> it against what's in the filesystem and report if we find discrepancies.
> This closes one of the major gaps in corruptions that are detected by
> xfs_check vs. xfs_repair.
This looks pretty good!
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
One nitpick below:
> +/* Initialize an incore dquot tree. */
> +static struct qc_dquots *
> +qc_dquots_init(
> + uint16_t type)
> +{
> + struct qc_dquots *dquots;
> +
> + dquots = calloc(1, sizeof(struct qc_dquots));
> + if (!dquots)
> + return NULL;
> +
> + dquots->type = type;
> + pthread_mutex_init(&dquots->lock, NULL);
> + avl64_init_tree(&dquots->tree, &qc_cache_ops);
> + return dquots;
> +}
I'd name this something will alloc instead of init as it allocates the
qc_dquots structure.
