On Wed, Jul 15, 2020 at 08:38:35AM -0400, Brian Foster wrote:
> index c3be6e440134..6a6a79791fbb 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -542,11 +542,11 @@ xfsaild_push(
> xfs_trans_ail_cursor_done(&cur);
> spin_unlock(&ailp->ail_lock);
>
> +out_done:
> if (xfs_buf_delwri_submit_nowait(&ailp->ail_buf_list))
> ailp->ail_log_flush++;
>
> if (!count || XFS_LSN_CMP(lsn, target) >= 0) {
> -out_done:
Nit: if you move the out_done up a bit we can also de-duplicate the
xfs_trans_ail_cursor_done and spin_unlock calls.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
