On Fri, Jul 10, 2020 at 05:11:11PM +0100, Christoph Hellwig wrote: > On Fri, Jul 10, 2020 at 11:15:36AM +0200, Carlos Maiolino wrote: > > xfs_da_state_alloc() can simply be replaced by kmem_cache_zalloc() > > calls directly. No need to keep this helper around. > > Wouldn't it be nicer to keep the helper, and also make it setup > ->args and ->mp? Yup, sounds good, thanks for the suggestion, I'll update the patch accordingly. -- Carlos