On Thu, Jul 02, 2020 at 07:30:21AM +0100, Christoph Hellwig wrote: > On Wed, Jul 01, 2020 at 11:25:08AM -0700, Darrick J. Wong wrote: > > > /* > > > * Ensure we got the type and ID we were looking for. Everything else > > > * we checked by the verifier. > > > */ > > > if ((ddqp->d_flags & XFS_DQ_ALLTYPES) != dqp->dq_flags || > > > ddqp->d_id != dqp->q_core.d_id) > > > > Sounds good to me. I'll make that change. > > We also don't need the mask on the on-disk flags, as it never contains > anything but the type, so this can be further simplified. d_flags will contain more than the type Real Soon Now; I was planning to send out the y2038 feature patchset (at least for another RFC) right after landing this series. --D
