On Wed, Jul 01, 2020 at 09:47:14AM +0100, Christoph Hellwig wrote: > > #define XFS_DQ_ALLTYPES (XFS_DQ_USER|XFS_DQ_PROJ|XFS_DQ_GROUP) > > > > +#define XFS_DQ_ONDISK (XFS_DQ_ALLTYPES) > > + > > I really wonder if we should split the on-disk type and the in-core > flags properly instead. > > That is propagate the u8 flags from the on-disk field directly, > and use a separate field for the in-memory flags dirty and freeing > flags, as that this kind of mixing up is bound to eventually create > problems. I was already half-inclined to try to separate them anyway, guess I'll add that to this series. --D
