On Wed, Jun 24, 2020 at 06:18:31PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Refactor the two functions that we use to lock and unlock two inodes to > block userspace from initiating IO against a file, whether via system > calls or mmap activity. This seems to miss an explanation of what is actually changed. From inspect it passes inodes instead of files to the unlock helper, and adds a lock two inodes helper, which looks fine to me. > --- a/fs/xfs/xfs_reflink.h > +++ b/fs/xfs/xfs_reflink.h > @@ -56,7 +56,6 @@ extern int xfs_reflink_remap_blocks(struct xfs_inode *src, loff_t pos_in, > loff_t *remapped); > extern int xfs_reflink_update_dest(struct xfs_inode *dest, xfs_off_t newlen, > xfs_extlen_t cowextsize, unsigned int remap_flags); > -extern void xfs_reflink_remap_unlock(struct file *file_in, > - struct file *file_out); > +extern void xfs_reflink_remap_unlock(struct xfs_inode *ip1, struct xfs_inode *ip2); This adds an overly long line. Trivially fixed by dropping the pointless extern..
