The xfs_trans_roll in _removename is not needed because invalidating blocks is an incore-only change. This is analogous to the non-remote remove case where an entry is removed and a potential dabtree join occurs under the same transaction. Signed-off-by: Allison Collins <allison.henderson@xxxxxxxxxx> --- libxfs/xfs_attr.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c index 0b81bf5..a743900 100644 --- a/libxfs/xfs_attr.c +++ b/libxfs/xfs_attr.c @@ -1148,10 +1148,6 @@ xfs_attr_node_removename( if (error) goto out; - error = xfs_trans_roll_inode(&args->trans, args->dp); - if (error) - goto out; - error = xfs_attr_rmtval_invalidate(args); if (error) return error; -- 2.7.4
